Skip to content

Import spdxtool from pkgconf into the base system #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
khorben wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Import spdxtool from pkgconf into the base system #1994

khorben wants to merge 9 commits into from

Conversation

@khorben
Copy link
Contributor

@khorben khorben commented Jan 28, 2026

This series of commits includes two major components:

  • Vendor import of pkgconf (versions 2.4.3, 2.5.1, plus development snapshot) into a dedicated branch through a merge commit
  • Import pkgconf into the base system, complete with bomtool (for SPDX 2.2) and spdxtool (for SPDX 3.0.1)

This remains a draft pull-request for the moment because:

  • It is not clear to me yet if libpkgconf should be made private (I suppose it should be)
  • There has been no wide discussion nor consensus about the need to import spdxtool into the base system
  • The actual changes required for CRA compliance and/or generation of SPDX files in the base system are not determined as of now, this is part of the corresponding R&D process
  • I have not studied the possibility of conflicts with pkgconf from ports yet

However I am taking this opportunity to bring visibility and open that discussion, giving an early chance for review as this effort is going.

@khorben
Vendor import of pkgconf version 2.4.3
d2cad9e 
Obtained from github.com/pkgconf/pkgconf, at tag pkgconf-2.4.3
(1d37e711cefe83e6b5393b424af4c94da4e7e9d3).
@khorben
Add 'contrib/pkgconf/' from commit 'd2cad9e63dc7ce574e8df3d57405a622f…
a0dea30 
…59197b2'

git-subtree-dir: contrib/pkgconf
git-subtree-mainline: 64ee9c1
git-subtree-split: d2cad9e
@khorben
Import pkgconf 2.4.3
26a141a
@khorben
Vendor import of pkgconf version 2.5.1
4e43971 
Obtained from github.com/pkgconf/pkgconf, at tag pkgconf-2.5.1
(4fc570f91d9d8d843ab32d2198a5c064538d8ffd).

This also removes the .git?* files from the import.
@khorben
Merge commit '4e43971748c9ed8fe436ecaa3d686583dfa790b0' into khorben/…
582a8c2 
…pkgconf-2.5.1
@khorben
Import pkgconf 2.5.1
4fc6c94
@khorben
Vendor import of pkgconf (main branch)
63478c5 
Obtained from github.com/pkgconf/pkgconf, at latest commit
(0c2743f6e3698d324ac5be0dbb1ad2c09a7da6fe).
@khorben
Merge commit '63478c57c59e7f4fbdbcc13157b0d98d1a5d5efa' into khorben/…
f4dff5e 
…spdxtool
@khorben
Import pkgconf 2.5.1 with spdxtool
553f6d9
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Thank you for taking the time to contribute to FreeBSD!

Some of files have special handling:

Warning

contrib: Contributed software usually managed by vendor branch

@bsdimp bsdimp self-assigned this Jan 28, 2026
@bsdimp
Copy link
Member

bsdimp commented Jan 28, 2026

So with vendor branches, this pull request can't be landed. But that's a silly process thing: this review looks like it is open for discussion and refinement and for that, this is as good a place as any.

@concussious
Copy link
Contributor

concussious commented Jan 30, 2026

So, why should we import spdxtool to the base system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsdimp bsdimp Awaiting requested review from bsdimp bsdimp will be requested when the pull request is marked ready for review bsdimp is a code owner

@bapt bapt Awaiting requested review from bapt bapt will be requested when the pull request is marked ready for review bapt is a code owner

Assignees

@bsdimp bsdimp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khorben @bsdimp @concussious